DiamondLightSource / DiamondLightSource/dodal
Fix test_grid_overlay OAV system test
- Dominant language
- Python
- Stars
- 5
- Forks
- 13
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 10
Description
This test is currently failing on `main` but is skipped so it's not notice. It at least needs to actually connect the PVs with `async with init_devices(connect=True):` but even then there is a timeout.
FYI @DiamondLightSource/developers-mx-daq, I can try and fix this if I get a bit of time but it's not used outside MX AFAIK
## Acceptance Criteria
* The test is fixed or removed
Contributor guide
Research direction
Start by locating the skipped test_grid_overlay OAV system test and inspect how it initializes its PVs. Try the mentioned async with init_devices(connect=True) setup, then investigate the timeout while running the test. Done means the test passes reliably or is removed, as specified by the acceptance criteria.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100