DiamondLightSource / DiamondLightSource/dodal

Remove the Jungfrau Commissioning Detector

Open
#1,982 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
5
Forks
13
Avg merge
3d 2h
Merged PRs (30d)
10

Description

Currently the Jungfrau has two implementations:
1. `CommissioningJungfrau` - https://github.com/DiamondLightSource/dodal/blob/working_commissioning_jf/src/dodal/devices/beamlines/i24/commissioning_jungfrau.py
2. `Jungfrau` - https://github.com/bluesky/ophyd-async/blob/5f878e85dc20236c0a56c7174a9a4d1dc4fea8fe/src/ophyd_async/fastcs/jungfrau/_detector.py#L10

The `CommissioningJungfrau` was needed because odin was not working and we needed a temporary file writer, which this uses, whereas `Jungfrau` uses odin. However, odin is now thought to be mostly working.

`ophyd-async` has recently updated the way that `StandardDetector`s need to be implemented, the `Jungfrau` detector in `ophyd-async` has been updated accordingly but `ComissioningJungfrau` has not.

Given the imminent dropping of `ComissioningJungfrau` it was decided (by @DominicOram and @phathaway) to not update it to the latest `ophyd-async` and instead remove it.

The `ComissioningDetector` remains on the beamline for testing as well as in the `working_commissioning_jf` branch if needed in the future.

However, this means there is the assumption that next time we update i24 it will be to use odin for the jungfrau.

## Acceptance Criteria
* i24 is updated to use the Jungfrau in `ophyd-async`
* `CommissioningJungfrau` is removed from `main`

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.