DiamondLightSource / DiamondLightSource/dodal

Convert location to domain name in BeamlinePrefix

Open
#1,916 0 comments 0 reactions 0 assignees View on GitHub
good first issue
Dominant language
Python
Stars
5
Forks
13
Avg merge
3d 2h
Merged PRs (30d)
10

Description

Currently, we do this:
```python
BL = "b01-1"
PREFIX = BeamlinePrefix(BL, suffix="C") #PREFIX=="BL01C"
```
where `b01-1` is the 'location' (i.e., the short domain) and `BL01C` is the domain name.

It would be nicer to provide `BeamlinePrefix` with the location, allowing it to do these conversions:
```
ixx -> BLxxI
ixx-1 -> BLxxJ
kxx -> BLxxK
bxx -> BLxxB
bxx-1 -> BLxxC
```
and accept an override to select the trailing domain letter, for exceptions such as `i13-2`

## Acceptance Criteria
* Do not have to provide suffix for known `location`->`domain` conventions

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.