DiamondLightSource / DiamondLightSource/dodal

Get beamline params from beamline files

Open
#1,855 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
5
Forks
13
Avg merge
3d 2h
Merged PRs (30d)
10

Description

> Could: This is a bit of scope creep but the way we're doing this is a bit messy. I think we can do it like we do https://github.com/DiamondLightSource/dodal/blob/d245f0ae6b37f73590919b1e645bb3b6969f343a/src/dodal/beamlines/i03.py#L92 and load it in as part of the beamline file. If that makes sense? Can you either do here or make a new issue?

_Originally posted by @DominicOram in https://github.com/DiamondLightSource/dodal/pull/1773#discussion_r2707305295_

Currently, we have a `get_beamline_parmeters()` function in `dodal/common/` that can be called to retrieve beamline parameters where needed. It would be cleaner to have a per-beamline function in `ixx.py`, and then beamline params can be passed in to devices when initialised.

There's still a question of how to get beamline parameters in common plans.

## Acceptance Criteria
* Each beamline file has a `get_beamline_parameters` function
* Devices that require beamline parameters recieve them when initialised.
* Common plans that require beamline parameters still work

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.