DiamondLightSource / DiamondLightSource/dodal

Multiple Bimorph Mirrors without Identification

Open
#1,806 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
5
Forks
13
Avg merge
3d 2h
Merged PRs (30d)
10

Description

As a programmer I would like to know which bimorph mirror dodal class is appropriate for the physical bimorph mirror in a given beamline.

There are currently multiple in dodal: the `dodal.devices.bimorph_mirror.BimorphMirror` (for CAENels mirors) and `dodal.devices.focusing_mirror.FocusingMirrorWithPiezo`.

These are for different makes of bimorph mirror, but this is unclear from the code.

## Acceptance Criteria
- The bimorph mirror classes are clearly identified to bimorph mirror device they represent

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.