DiamondLightSource / DiamondLightSource/dodal

Remove capitalised enums found in common

Open
#1,416 0 comments 0 reactions 0 assignees View on GitHub
Developer Experience enhancement standarisation
Dominant language
Python
Stars
5
Forks
13
Avg merge
3d 2h
Merged PRs (30d)
10

Description

With https://github.com/DiamondLightSource/dodal/issues/1402, we have made an effort to standardise some common emuns. However, we still have many capitalised versions of the same enums that are used in various devices. We should make an effort to try and standardise this further and ask controls for these devices using the capitalised ones to be updated.

For example:

```Python
class OnStateCapilised(StrictEnum):
ON = "ON"
OFF = "OFF"
```

Any devices using above should speak with controls and ask them to update it to

```Python
class OnState(StrictEnum):
ON = "On"
OFF = "Off"
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.