DiamondLightSource / DiamondLightSource/dodal

Stop processing Murko results when redis sends end of rotation message

Open
#1,239 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
5
Forks
13
Avg merge
3d 2h
Merged PRs (30d)
10

Description

> Hmm... We should probably be able to stop based on a message from redis saying that we've reached the end of the rotation. Can you make an issue for that?

_Originally posted by @DominicOram in https://github.com/DiamondLightSource/dodal/pull/1175#discussion_r2100405307_

We should change the `murko_results` device to stop processing results once we get a message from redis saying we've reached the end of the rotation, rather than once we reach an arbitrary angle. If redis already provides such a message, we can just check each message to see if the rotation has ended. If not, we need to make sure such a message is sent.

Requires https://github.com/DiamondLightSource/dodal/pull/1175

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.