DiamondLightSource / DiamondLightSource/dodal

Make CONTRIBUTING.md

Open
#1,010 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
5
Forks
13
Avg merge
3d 2h
Merged PRs (30d)
10

Description

From discussion with @DiamondJoseph ; there are non-trivial acceptance criteria to PRs that could be more explicit.

- does device connect - on one beamline, or all?
- when do we allow 'skip_device' in a PR?
should PR code correspond to the beamline reality at merge OR to the model of beamline reality and the exact details could be worked in a separate PR?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.