DiamondLightSource / DiamondLightSource/daq-queuing-service
i15-1: Generate capillary names from the graph
- Dominant language
- Python
- Stars
- 0
- Forks
- 1
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 16
Description
> I think the capillaries are the same as those at https://github.com/DiamondLightSource/ulims-json-schemas/blob/9c156ced3504787f98b102747b28e4afba152292/schemas/samples/i15-1/powder/0.0.1.json#L38, which we can pull out of the graph. Happy to put this in another issue. We should also check with the beamline as this is a weirdly long list. It may be that we just need bs, fq, pi.
Currently we hard the code capillary types in the i15-1 queue plugin. As @DominicOram pointed out above, these can be generated from the graph automatically.
## Acceptance Criteria
- Capillary names are generated from the schema and not hard coded
- Have checked with beamline staff if the full list is needed
Contributor guide
Research direction
Start with the i15-1 queue plugin and the linked powder schema, then trace where capillary types are currently hard coded and how the graph is accessed. Confirm with beamline staff whether the full schema list is required; done means names come from the schema and the hard-coded list is removed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100