DiamondLightSource / DiamondLightSource/daq-config-server

Discussion: Should we allow converters that go to dict as well as converters that go to basemodels?

Open
#136 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
1
Forks
2
Avg merge
1d 12h
Merged PRs (30d)
2

Description

This is the current behaviour, but could cause confusion. See [comment](https://github.com/DiamondLightSource/daq-config-server/pull/129#discussion_r2588349695)

## Acceptance Criteria
- Decide and make changes if needed

Contributor guide

Open the contributing guide

Research direction

Start by reading the linked discussion on pull request #129 and tracing the current converter behavior described there. Decide whether converters to dict and BaseModel should both be allowed; if changes are needed, update the relevant implementation and tests, but the issue names no files or tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.