DiamondLightSource / DiamondLightSource/cs-web-lib

Alarm sensitivity is not handled correctly

Open
#51 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
5
Forks
4
Avg merge
3d 59m
Merged PRs (30d)
3

Description

Currently cs-web-lib uses the property `border_alarm_sensitive` to decide whether to show a widget in the alarm state. This is inconsistent with the CSS implementation where the widget always acknowledges the alarm state and the user can optionally decide to also show this as a border.

**CSS** implementation for `border_alarm_sensitive`. Note that if false it still displays the value as red indicating it is in alarm state.
![css_alarm](https://github.com/dls-controls/cs-web-lib/assets/45264327/13ef0752-8ded-442e-8e25-94f0100ceaac)

**WebUI** implementation. Note that when `border_alarm_sensitive=false` we get no alarm information
![webui_alarm](https://github.com/dls-controls/cs-web-lib/assets/45264327/1f87283a-0faa-4036-beb7-5eccf0b44459)

Contributor guide

No contributing guide indexed for this repository

Research direction

Compare the WebUI handling of `border_alarm_sensitive` with the CSS behavior described in the issue, starting from the widget alarm-state logic. Done means the widget still shows its alarm state when the property is false, while the property only controls whether the alarm is also shown as a border; verify the behavior against the supplied examples.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.