DiamondLightSource / DiamondLightSource/cs-web-lib

Implement remaining Plot widget changes

Open
#19 1 comment 0 reactions 1 assignee Claimed by @abigailalexander View on GitHub
priority:1
Dominant language
TypeScript
Stars
5
Forks
4
Avg merge
3d 59m
Merged PRs (30d)
3

Description

While most of the suggested changes to the [Plot widget PR](https://github.com/dls-controls/cs-web-lib/pull/15) have been made, there are still some outstanding changes not yet implemented. These are:

- [ ] Possibly extract part of `opiParser.ts` function `parseMultipleNamedProps` to make it reusable for other functions
- [ ] Be more precise for types of `obj` and `props` in `parseMultipleNamedProps`, rather than using `any`
- [ ] Consider whether we want to apply the same limit on maximum number of traces (20) as CSStudio does
- [ ] Currently only support plotting waveform PVs - we want to be able to plot time series data - this involves getting the data concatenation working as well as modify the way incoming data is handled
- [ ] Decide whether to use test() or it() for unit tests and enforce this change (this is not necessarily related to the plot widget specifically, but worth mentioning)
- [ ] Add tests for xyPlot.ts

Hopefully by implementing these changes, the Plot widget would be complete.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.