DiamondLightSource / DiamondLightSource/crystallography-bluesky

i15-1: Call real centring analysis

Open
#80 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
0
Forks
0
Avg merge
21h 40m
Merged PRs (30d)
8

Description

Following https://github.com/DiamondLightSource/crystallography-bluesky/pull/76 we are now calling analysis at the end of doing a centring scan. However, we're calling a dummy analysis, we should instead call the centring analysis and use the result.

To make this work nicely it would be good if @RJCD-Diamond could provide us with the centre of the scan, as read from the nexus file

## Acceptance Criteria
- The centring analysis is called on the centre sample plan
- We use the result as returned from analysis

Contributor guide

Open the contributing guide

Research direction

Review pull request 76 and trace the centre sample plan through the centring scan to find where the dummy analysis is called. Check how the centring analysis result is represented, then verify that the real analysis is called and its returned result is used; the Nexus-file centre is relevant context.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.