DiamondLightSource / DiamondLightSource/cothread

Cothread beyond version 2.18.2 can break long string handling in affected servers

Open
#53 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
13
Forks
11
PR merge metrics
No merged PRs in 30d

Description

Commit 1ec3579761d4b1901bf65d0c1e58b063191273df of PR #32 changes the behaviour of puts to "long strings" (arrays of char) so that a trailing null is no longer sent. This makes the length of the string (as reported by `.NORD`) truthful, but unfortunately can trigger bugs in string length calculations in certain servers.

Either cothread should unconditionally append an extra null (making all strings one character longer than is truthful) or this could be done conditionally on something like an environment variable.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.