DiamondLightSource / DiamondLightSource/bluesky-stomp

MessagingTemplate disconnect method should be idempotent

Open
#22 1 comment 1 reaction 0 assignees View on GitHub
bug
Dominant language
Python
Stars
1
Forks
0
PR merge metrics
No merged PRs in 30d

Description

The disconnect method for the messaging errors if called when it is already disconnected. Instead it should do nothing. To avoid this causing issues the `stop` method in service handler has had a if statement added to it to check if its connected before trying to disconnect it, but this should be able to be taken back out.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.