DiamondLightSource / DiamondLightSource/blueapi

Get instrument_session (dls term) and data_session (bluesky term) to play together nicely

Open
#865 1 comment 0 reactions 0 assignees View on GitHub
priority low
Dominant language
Python
Stars
13
Forks
13
Avg merge
2d 11h
Merged PRs (30d)
25

Description

At DLS we have moved to use the terms instrument and instrument session to replace beamline and visit respectively. I have reflected this move in this PR https://github.com/DiamondLightSource/blueapi/pull/846 however we need to make sure instrument session is used correctly as data session within bluesky.

From that PR callum suggested:

> I propose using instrument_session everywhere in this codebase, and interfacing to bluesky via a constant e.g.
> ```
> INSTRUMENT_SESSION = "data_session"
>
> # somewhere else in the codebase
>
> instrument_session = start_document[INSTRUMENT_SESSION]
> ```
> That we we keep our own terms consistent and provide bluesky with it's preferred terms

## Acceptance Criteria
- Specific criteria that will be used to judge if the issue is fixed

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.