DiamondLightSource / DiamondLightSource/blueapi

Return exception info from `with_dodal_module` and `with_plan_module`

Open
#726 2 comments 0 reactions 0 assignees View on GitHub
c: context needs confirmation
Dominant language
Python
Stars
13
Forks
13
Avg merge
2d 11h
Merged PRs (30d)
25

Description

Recently importing our plans (mx-bluesky/hyperion) into the BlueApi context started failing with a new (2.10) version of pydantic, which when running `create_model` on the plan arguments fails when one is a `dataclasses.dataclass` containing devices, because the devices don't implement `__get_pydantic_core_schema__`. This would have been substantially easier to diagnose if we had the information that exceptions had occurred during the above functions available to us when running them

## Acceptance Criteria
these methods have return values that allow the caller to determine if an exception happened and some info about it

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.