DiamondLightSource / DiamondLightSource/blueapi

StopDocuments should include more data

Open
#1,558 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
13
Forks
13
Avg merge
2d 11h
Merged PRs (30d)
25

Description

Here is an example of a StopMessage and StopDocument

{
"name": "stop",
"doc": {
"uid": "a5af9bbc-13d6-4d1f-aaab-ed076935b4a5",
"time": 1781265600.6895273,
"run_start": "4e6741e0-be66-4899-8794-e372021cd617",
"exit_status": "success",
"reason": "",
"num_events": {"baseline": 2, "primary": 1},
},
"task_id": "a3b4dd7c-017f-4adc-b9cc-07bb7548bb97",
}

But the information I really need is in the StartDoc Specifically:

"instrument": "i15-1",
"instrument_session": "cm44163-3",
"data_session_directory": "/dls/i15-1/data/2026/cm44163-3",
"detector_file_template": "{instrument}-{scan_id}-{device_name}",
"scan_file": "i15-1-96680",
"scan_id": 96680,
"plan_name": "static_collection_plan",

I can access data by finding the start document by looking at the run_start id ```"run_start": "4e6741e0-be66-4899-8794-e372021cd617"``` and then going to find the RunStart, but this adds complexity, and if kinda awful. This is the way workflows is trying to implement it

I would like it if the StopDocument contained the same info as the start doc. The RunStop from event_model allows extra so it should be easy.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.