DiamondLightSource / DiamondLightSource/blueapi

Numtracker client passes user supplied visit directly

Open
#1,199 0 comments 1 reaction 0 assignees View on GitHub
bug external
Dominant language
Python
Stars
13
Forks
13
Avg merge
2d 11h
Merged PRs (30d)
25

Description

## Steps To Reproduce
1. Run blueapi using system test config (with services running)
2. Run a scan using `cm12345-6", sub: "foo` as the visit, eg
```shell
blueapi -c tests/system_tests/config.yaml controller run -i 'cm12345-6", sub: "foo' spec_scan '{"detectors":["det"], "spec":{"axis": "stage.x", "start": 1.0, "stop": 8.0, "num": 8, "type": "Line"}}'
```
3. See that numtracker was queried for the given subdirectory

At the moment it doesn't really affect anything because the scan file path returned from numtracker is not used anywhere but if it ever is, we should probably validate the visit.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.