DiamondLightSource / DiamondLightSource/blueapi

Propagate instrument_session into requests to other blueapis

Open
#1,187 2 comments 0 reactions 0 assignees View on GitHub
decision pending
Dominant language
Python
Stars
13
Forks
13
Avg merge
2d 11h
Merged PRs (30d)
25

Description

For end stations with shared optical components we currently have N+1 instances of blueapi, with the +1 choreographing access to the shared components. Since version 1.0.0 we require the instrument session to be passed with the request. As the shared blueapi should not write any data, this instrument session is not used, and for now is being passed a commissioning visit for the beamline.

We should come up with a permanent solution for this, such as propagating the instrument session, making the instrument session optional (this will cause issues if we start checking authorization to move motors, even if it gets around the current requirement which is only to enforce permission to write data).

Or revisiting https://github.com/DiamondLightSource/dodal/issues/503 and finding a solution.

## Acceptance Criteria
- Specific criteria that will be used to judge if the issue is fixed

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.