DiamondLightSource / DiamondLightSource/atlas

i15-1: Improvements to the queue UI

Open
#56 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1
Forks
4
Avg merge
6d 8h
Merged PRs (30d)
8

Description

Spinning this into a new issue. See the comments below on the current implementation of the queue UI

- [ ] Should: The pause will pause after the next task in the queue is finished, I think it would be good to rename it to make that more obvious
- [ ] Should: This PR includes stuff for the abort button, we should probably have the same button on the queue page (in fact maybe everywhere)
- [ ] Could: I think some tooltips on the column headers would be good
- [ ] Nit: You can filter by the action column, this doesn't really make much sense
- [ ] Nit: Status is an enum but when you filter by it you put in a string, might be nicer if the filter was an enum

_Originally posted by @DominicOram in https://github.com/DiamondLightSource/atlas/pull/45#pullrequestreview-4403224154_

Questions:
- Can we show plan parameters as [Label: Value] list or expanded list in a different way? not showing the curly brackets?
- Do we need "Sort order" on this? Or is it always to be shown by position order?
- What does "Cancel" do? Can we rename to more explicit?

For later:

- Sort should be hidden and activated on mode "Sort table" button, saved automatically, with an Exit button (this is so we don't have accidental ordering).
- Spacing needs to be looked at. The default density to too big, and the small one is too tight. Need to tighten it slightly. I need to understand how the spacing works in MRT, not sure if this is done by changibg padding or the line size of object within. Also, action columns have smaller padding by default.

_Originally posted by @zoharma in https://github.com/DiamondLightSource/atlas/pull/45#pullrequestreview-4403224154_

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.