DiamondLightSource / DiamondLightSource/atlas

RunPlanButton should deal with no instrument session selected

Closed Beginner friendly
#195 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1
Forks
4
Avg merge
6d 8h
Merged PRs (30d)
8

Description

If no instrument session is selected, a plan cannot be run. A default should not be provided, as this will likely only cause further errors downstream.

The RunPlanButton should allow a `null` instrumentSession, and refuse to submit the plan, raising an error and notifying the user that no session is selected.

Contributor guide

No contributing guide indexed for this repository

Research direction

Locate the RunPlanButton component and follow its plan-submission path. Check how an absent instrument session is represented and how user errors are notified. Done means no default session is supplied, submission is refused when the session is null, and the user is told that no session is selected.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
72/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.