DiamondLightSource / DiamondLightSource/aioca
Make `bool(CANothing)` always return True
Open
- Dominant language
- Python
- Stars
- 9
- Forks
- 5
- PR merge metrics
- No merged PRs in 30d
Description
https://github.com/dls-controls/aioca/blob/12a0a68c249b90cd375b9432ed438c7a7e85ab97/aioca/_catools.py#L92-L93
Causes issues with various python internals, like `concurrent.futures.result` which does:
https://github.com/python/cpython/blob/d5a8d4b19670b930cd6cb5e18e267877ebe49233/Lib/concurrent/futures/_base.py#L399
So if we put a `CANothing` in as a result it shows as no exception...
Contributor guide
Assessment
This issue has not been assessed yet.