DiamondLightSource / DiamondLightSource/ImagingHub

Failure to generate config file results in "success" notification

Open
#89 0 comments 0 reactions 0 assignees View on GitHub
bug good first issue
Dominant language
TypeScript
Stars
2
Forks
1
Avg merge
7h 4m
Merged PRs (30d)
24

Description

In the "Methods" page, even when the config file fails to be generated (for example, when clicking the "Get Config" button after a refresh of the page, so the page is completely blank), a notification pops up saying "Configuration file generated successfully", which is misleading.

See the screenshot below for an example:

Image

The error likely resides in the component in `YamlGenerator.tsx`, somewhere in the error-handling logic for when the snackbar should or shouldn't be displayed.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.