DiamondLightSource / DiamondLightSource/ImagingHub

Revaluate if use of -1 value is intuitive

Open
#72 0 comments 0 reactions 1 assignee Claimed by @Oli-Jones475 View on GitHub
Dominant language
TypeScript
Stars
2
Forks
1
Avg merge
7h 4m
Merged PRs (30d)
24

Description

Found another case where a value of -1 is being used where it's possible that something like an optional type would be more intuitive: https://github.com/DiamondLightSource/TomoHub/blob/b98db1054e7e6a143b0e6a416bf4646f1192015e/frontend/src/components/crop/SelectionOperations.ts#L55-L57

It'd be worth quickly reviewing this and the context in which it's being used to see if a value of -1 is the best way to express the desired behaviour.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.