DiamondLightSource / DiamondLightSource/ImagingHub

Redundant tag-push check in push step of container image build workflow file

Open
#29 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
2
Forks
1
Avg merge
7h 4m
Merged PRs (30d)
24

Description

The workflow is configured to trigger on a push of a git tag: https://github.com/DiamondLightSource/TomoHub/blob/c931d678180cb6c53a55f214e9672e38b6300775/.github/workflows/_tomohub.yml#L3-L6

and yet the final step is checking if the event was a "push" and if there's a tag before the step runs (which is pushing the built container image): https://github.com/DiamondLightSource/TomoHub/blob/c931d678180cb6c53a55f214e9672e38b6300775/.github/workflows/_tomohub.yml#L59

The latter check is redundant due to the former already constraining the workflow to run only on a push of a tag.

Contributor guide

No contributing guide indexed for this repository

Research direction

Inspect .github/workflows/_tomohub.yml, especially the tag trigger near lines 3-6 and the final container-image push step near line 59. Confirm the trigger already limits runs to tag pushes, then remove the redundant condition and verify the workflow still pushes the image for tag-triggered runs.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, github-actions
Domain
ci-cd, devops
Issue type
Refactor
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.