DiamondLightSource / DiamondLightSource/ImagingHub
Return error HTML page if visiting non-existent route
- Dominant language
- TypeScript
- Stars
- 2
- Forks
- 1
- Avg merge
- 7h 4m
- Merged PRs (30d)
- 24
Description
In the build there's a simple page called `50x.html` that's intended for use as an error page to return to the user if they visit a non-existent route. We currently don't make use of this in the nginx config: https://github.com/DiamondLightSource/TomoHub/blob/8697a2af2fe374fa29c2ee1b28180be680aeeba4/frontend/nginx.conf#L1-L23
so at the moment, nothing is returned to the user's web browser (the page is blank). Returning this error page would be good to do.
Contributor guide
No contributing guide indexed for this repository
Research direction
Inspect frontend/nginx.conf at the linked lines and locate the built 50x.html page. Start by checking how non-existent routes are handled, then verify in a browser that such a route returns the error page instead of a blank response.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- nginx
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100