DiamondLightSource / DiamondLightSource/ImagingHub
Revaluate use of `type="number"` in MUI `TextField` component
- Dominant language
- TypeScript
- Stars
- 2
- Forks
- 1
- Avg merge
- 7h 4m
- Merged PRs (30d)
- 24
Description
There are some uses of this in the codebase, such as the following: https://github.com/DiamondLightSource/TomoHub/blob/067cbda673c64316dfdd9d91201b29c8b367215f/frontend/src/components/Loader.tsx#L271
but the React MUI library [docs](https://mui.com/material-ui/react-text-field/#type-quot-number-quot) at the time of writing state that use of `type="number"` is not advisable for "potential usability issues". See their docs page for more info.
Likely not an issue at the moment, but something worth bearing in mind.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with the referenced frontend/src/components/Loader.tsx location around line 271 and read the linked MUI TextField guidance. Search the codebase for other type="number" uses, then determine whether they should be changed and what replacement behavior is required. The issue does not define a concrete completion condition, so confirm the intended scope before starting.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100