Devolutions / Devolutions/picky-rs

Test failures on CTL parsing

Open
#257 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
69
Forks
42
PR merge metrics
No merged PRs in 30d

Description

The following tests started failing:

```
x509::pkcs7::authenticode::test::full_validation_authenticode_signature_with_well_known_ca
x509::pkcs7::authenticode::test::full_validation_self_signed_authenticode_signature
x509::pkcs7::authenticode::test::full_validation_self_signed_authenticode_signature_with_only_leaf_certificate
x509::pkcs7::authenticode::test::full_validation_self_signed_authenticode_signature_with_root_and_leaf_certificate
x509::pkcs7::authenticode::test::self_signed_authenticode_signature_validation_against_ctl
x509::pkcs7::authenticode::test::self_signed_authenticode_signature_validation_against_ctl_with_excluded_ca_certificate
x509::pkcs7::authenticode::test::self_signed_authenticode_signature_validation_against_ctl_with_excluded_not_existing_ca_certificate
x509::pkcs7::ctl::tests::create_ctl
```

In all cases, the error is

> panicked at 'called `Result::unwrap()` on an `Err` value: FailedToParseCtl(Cert(Asn1Deserialization { element: "pkcs7 certificate", source: InvalidData }))',

No commit in picky-rs can explain the regression; it's likely that something changed In Microsoft's serialized trust list. Although it's possible, I doubt the file is broken (it's used by Windows Update to update Windows' root certificates). Something in the current file is causing picky to choke.

As an interim measure, the tests were disabled in #256.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.