Devolutions / Devolutions/devolutions-gateway

unused_qualification lint warnings

Open
#1,071 1 comment 0 reactions 1 assignee Claimed by @allan2 View on GitHub
Dominant language
Rust
Stars
159
Forks
28
Avg merge
2d 23h
Merged PRs (30d)
21

Description

When running Clippy, there are lots of warnings like
```
warning: unnecessary qualification
--> crates\win-api-wrappers\src\thread.rs:175:54
|
175 | ThreadAttributeType::ParentProcess(_) => mem::size_of::(),
| ^^^^^^^^^^^^^^^^^^^^^^
|
help: remove the unnecessary path segments
|
175 - ThreadAttributeType::ParentProcess(_) => mem::size_of::(),
175 + ThreadAttributeType::ParentProcess(_) => size_of::(),
```

`std::mem::size_of` and `mem::size_of` both fail this lint.

I suggest removing the lint if the maintainers prefer to use `mem::size_of`, or to accept the lint suggestion, i.e., unqualified `size_of`.

I can make a PR for this pending guidance.

#1068 related

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.