Devolutions / Devolutions/IronRDP

Precursor — decouple consumers from the `ironrdp_connector::sspi` re-export

Open
#1,427 0 comments 0 reactions 0 assignees View on GitHub
kind/technical-debt scope/core scope/web
Dominant language
Rust
Stars
3.2k
Forks
275
Avg merge
1d 11h
Merged PRs (30d)
189

Description

`ironrdp-async`, `ironrdp-blocking`, `ironrdp-web`, and `ironrdp-acceptor` currently reach `sspi` through `ironrdp-connector`'s `pub use sspi` re-export. Switch them to a direct `sspi` dependency so that removing the re-export later (#1433) is a non-event and the CredSSP window PRs stay small. Independent, mechanical, and green on its own.

### Scope
- [ ] Add a direct `sspi` dependency to `ironrdp-async`, `ironrdp-blocking`, `ironrdp-web`, `ironrdp-acceptor`. (`ironrdp-client` doesn't use the re-export; ffi already has a direct `sspi` dep.)
- [ ] Replace `ironrdp_connector::sspi::…` imports with `sspi::…`.
- [ ] Leave `ironrdp-connector`'s `pub use sspi` in place for now — it is removed in #1433.

### Acceptance criteria
- No crate other than `ironrdp-connector` references `ironrdp_connector::sspi`.
- Workspace builds unchanged; no behavior change.

Contributor guide

No contributing guide indexed for this repository

Research direction

Update the Cargo manifests for ironrdp-async, ironrdp-blocking, ironrdp-web, and ironrdp-acceptor, then find their ironrdp_connector::sspi imports and switch them to sspi imports. Build the workspace to verify there is no behavior change. Done means only ironrdp-connector still references the re-export.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
build-system
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
78/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.