Devographics / Devographics/Monorepo

Clarify behaviour of None in checkbox group => should clear up all data including follow ups

Open
#290 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
178
Forks
55
Avg merge
1m
Merged PRs (30d)
2

Description

The "None" option of a CheckboxGroupSentiment component is slightly ambiguous, as the UX might not completely match the data model:

From UX standpoint:
- when checking "None", other elements are unchecked
- but currently, followups are not deleted
- checking other elements is disabled, but not follow up question
- you can't add a sentiment to None

![image](https://github.com/Devographics/Monorepo/assets/7983005/4f64be69-3896-4fe1-978f-88431f77e5fd)

From data model standpoint:
- elements are tied to a list of followups, that are just strings
- sentiment is just one kind of followup, comments could be another or whatever we want

This leads to scenarios like this, where you have a positive opinion of buttons, yet said you used none of those elements.

![image](https://github.com/Devographics/Monorepo/assets/7983005/1985341b-d467-479a-b62f-2f59fa3d3135)

The current behaviour might be the right one, but I feel like treating sentiment as a generic followup may be weird.
But perhaps "None" should be handled more "aggressively" and remove all follow-ups?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.