Devographics / Devographics/Monorepo

Broken Twitter avatars, verbose Twitter links

Open
#166 3 comments 1 reaction 0 assignees View on GitHub
a11y
Dominant language
TypeScript
Stars
178
Forks
55
Avg merge
1m
Merged PRs (30d)
2

Description

In Firefox using "Strict" for my privacy mode, Twitter avatars are missing (this image is from the home page):
Special Thanks and then four names in a 2×2 grid; each name is preceded by the same name in an invisible circle which clips some of the letters.

Thrilled that there is alt text, but the missing images also highlight that the links are duplicated. This adds unnecessary tab-stops and redundancy, not to mention it might make users think the different links go to different places. I suggest removing the links from the avatars and giving them `alt=""`.

As I tab through the page in NVDA, I get this (`Tab` is me pressing the Tab key):

> Lea Verou link
> `Tab`
> Lea Verou link heading level 4
> `Tab`
> Nicole Sullivan visited link
> `Tab`
> Nicole Sullivan visited link heading level 4
> `Tab`
> Philip Jägenstedt link
> `Tab`
> Philip Jägenstedt link heading level 4
> `Tab`
> Christopher Kirk-Nielsen link
> `Tab`
> Christopher Kirk-Nielsen link heading level 4

If I just let the page read through, from the "Special Thanks" heading I get:

> Special Thanks heading level 3
> link Lea Verou
> heading level 4 link Lea Verou
> Survey Design
> visited link Nicole Sullivan
> heading level 4 visited link Nicole Sullivan
> Survey Design
> link Philip Jägenstedt
> heading level 4 link Philip Jägenstedt
> Survey Design
> link Christopher Kirk-Nielsen
> heading level 4 link Christopher Kirk-Nielsen
> Logo Design

Related, I do not think those links need to _also_ be a heading (at any level).

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.