DesModder / DesModder/DesModder

Calculator Settings overrides query parameters

Open
#1,064 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
134
Forks
49
Avg merge
5h 2m
Merged PRs (30d)
15

Description

Description

When query parameters are included in the URL, they are overridden by the Calculator Settings plugin. This is usually not what you would expect to happen.

Steps to reproduce
  1. Enable "Core > Calculator Settings"
  2. Uncheck "Show performance meter"
  3. Navigate to https://www.desmos.com/calculator?showPerformanceMeter
  4. Performance meter is not visible
Potential solutions
  • Query params take priority over calculator settings (checking and unchecking the box while the param is in the URL would do nothing)
  • Disable the checkbox when the query param is present, and show a tooltip explaining why it's disabled
  • Query params take priority over Calculator Settings initially, but changing the state in Calculator Settings would cause it to then update the value

Whichever solution we go with, the presence of query params shouldn't persist changes to Calculator Settings, only override them

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with Calculator Settings enabled, "Show performance meter" unchecked, and the showPerformanceMeter query parameter in the URL. Trace the Calculator Settings and query-parameter handling; done means query parameters override the setting without persisting changes to Calculator Settings.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.