Deltares / Deltares/imod-python
investigate failing test unstructured partitioning + vertical hfb
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 41
- Forks
- 12
- Avg merge
- 21h 8m
- Merged PRs (30d)
- 1
Description
while working on #897 it was discovered that one of the cases for test_partitioning_unstructured_hfb does not pass tests comparing flow_horizontal_face before and after partitioning. The test skips edges in the partition boundary for these comparisons.
The case that gave problems had "concentric" as the partitioning scheme, and "hfb_vertical" for the hfb.
Now this test is skipped as an expected fail, but we should investigate what goes wrong, and either fix it or explain in the user documentation what goes wrong.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the test_partitioning_unstructured_hfb test and reproduce the concentric partitioning case with hfb_vertical. Compare flow_horizontal_face before and after partitioning while excluding partition-boundary edges, then determine whether the behavior should be fixed or explained in user documentation. Done means the expected failure is resolved or the documented limitation is clear.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100