Deltares / Deltares/imod-python
Logging is being used unnecessary in the unit tests
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 41
- Forks
- 12
- Avg merge
- 21h 8m
- Merged PRs (30d)
- 1
Description
In several unit tests Logging is being enabled and tested. The logging is however never being disabled.
This has the consequence that log file becomes bigger and bigger and the test become slower.
The tests where logging is being enabled are:
We need some kind of teardown that sets the logger back to the NullLogger
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the unit tests identified in the issue image and find where logging is enabled and tested. Add a teardown that restores the logger to NullLogger, then run the affected tests and verify logging is disabled afterward without increasing the log file or slowing subsequent tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100