Deltares / Deltares/imod-python
Remove duplicate logic between masking/regridding/clipping Modflow 6 simulations
Open
Nobody has claimed this yet.
refactor
- Dominant language
- Python
- Stars
- 41
- Forks
- 12
- Avg merge
- 21h 8m
- Merged PRs (30d)
- 1
Description
When #886 and #888 are done, we can generalize some duplicate logic between masking/regridding/clipping Modflow6 simulation objects.
For example:
- Boundary conditions can be assigned when clipping, might be useful to apply to regridding? (For example when regridding ConstantHeads of an iMOD5 simulation?)
- There is separate logic to find variables which can be clipped or masked. We can generalize this probably
- Checking if point data located in grid exterior
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
After #886 and #888 are complete, compare the masking, regridding, and clipping logic for Modflow 6 simulation objects. Review the separate handling of boundary conditions, selectable variables, and point data outside the grid; done means the duplicated logic is generalized across these operations.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100