Deltares / Deltares/imod-python

add tests for non-equidistant grids

Open
#857 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

needs tests
Dominant language
Python
Stars
41
Forks
12
Avg merge
21h 8m
Merged PRs (30d)
1

Description

Many recently added functions ( clipping, regridding, partitioning, masking) are not tested on non-equidistant grids.
We should test what features work and what features don't, and then we can decide what we want to fix and what we won't support for such grids.
If we won't support a feature for non-equidistant structured grids we should add a user warning or error message.
One way to test all this is to use xugrid (through imod-python functionality) to regrid existing equidistant structured test-models to non-equidistant grids (and while at it, to triangles and voronoi cells ). This last step could reduce the number of models in the testbank significantly, because we would create a single set of structured equidistant test-models and use each model 4 times:

  1. as is
  2. regridded to non-equidistant
  3. regridded to triangles
  4. regridded to voronoi.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the existing structured equidistant test-models in the testbank and the clipping, regridding, partitioning, and masking tests. Use xugrid through imod-python functionality to create non-equidistant, triangular, and voronoi variants, then record which features work or fail. Done means the supported cases are covered and unsupported cases produce the required warning or error.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing-qa
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.