Deltares / Deltares/imod-python

Investigate if forcing IHC=2 leads to any performance issues

Open
#566 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
41
Forks
12
Avg merge
21h 8m
Merged PRs (30d)
1

Description

We want to add support for IHC mode 2

Notes:

  • According to the Modflow readthedocs:
    ihc is an integer flag indicating the direction between node n and all of its m connections. If IHC = 0 then the connection is vertical. If IHC = 1 then the connection is horizontal. If IHC = 2 then the connection is horizontal for a vertically staggered grid.

  • We don't expect many changes for supporting IHC=2 mode. The cl1,cl2 and hwva values should be computed the same way as for IHC1. CDist does differ and needs to be accounted for. In most cases the vertical component
    of the distance of CDist is negligible

  • We won't implement IHC=0. We only support horizontal partitioning

Questions:

  • Would forcing IHC=2 lead to any performance issues

Notes:

  • Ask Martijn about any theoretical consequences
  • Do stress test, preferably with converted LHM case (Ask Teun or Huite for this data)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the Modflow definition of IHC=2 and consult Martijn about its theoretical consequences. Obtain a converted LHM case from Teun or Huite, then run stress tests comparing IHC=1 and forced IHC=2 behavior and performance. Done means documenting whether performance or correctness is affected and identifying the required implementation scope.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
performance
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.