Deltares / Deltares/imod-python
imod.util.mdal_compliant_ugrid2d should also accept UgridDatasets directly
Open
Nobody has claimed this yet.
Deltares
story
- Dominant language
- Python
- Stars
- 41
- Forks
- 12
- Avg merge
- 21h 8m
- Merged PRs (30d)
- 1
Description
In GitLab by @betsyromero on Aug 10, 2023, 10:05
Currently this is required:
for_qgis = imod.util.mdal_compliant_ugrid2d(back.dataset.ugrid.to_dataset())
While this would be a lot more convenient:
for_qgis = imod.util.mdal_compliant_ugrid2d(back)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate imod.util.mdal_compliant_ugrid2d and inspect how it currently handles back.dataset.ugrid.to_dataset(). Extend the accepted input so the function also handles back directly, then verify both the existing dataset call and the direct UgridDataset call produce the expected result.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100