Deltares / Deltares/imod-python

Additional options in Simulation: continue, nocheck, memory_print_option, maxerrors

Open
#439 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement story
Dominant language
Python
Stars
41
Forks
12
Avg merge
21h 8m
Merged PRs (30d)
1

Description

In GitLab by @Huite on Jun 20, 2023, 07:19

The current init of Modflow6Simulation only takes a name. It would be good to support the additional options that have been added:

  • continue
  • nocheck
  • memory_print_option
  • maxerrors

The memory print option is especially useful for coupled models with imod_coupler.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the Modflow6Simulation initialization and the code that assembles its MODFLOW 6 options. Check how the existing name is handled, then determine how continue, nocheck, memory_print_option, and maxerrors should be represented, with particular attention to coupled models using imod_coupler. Done means all four options are supported and their values are covered by the relevant tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.