Deltares / Deltares/imod-python
Wrap non-intuitive xarray functions in utils
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 41
- Forks
- 12
- Avg merge
- 21h 8m
- Merged PRs (30d)
- 1
Description
In GitLab by @Huite on Nov 24, 2022, 16:12
We've already wrapped e.g. where, but also slice, which requires putting ymax before ymin.
There are probably many other cases like this. We should tabulate these here.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the existing utils wrappers for xarray functions such as where and slice, then inspect how their argument ordering differs from the underlying functions. Identify and tabulate the other non-intuitive cases described by the issue, and consider the work complete when the agreed cases are consistently wrapped in utils.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100