Deltares / Deltares/imod-python
laplace_interpolate does not check x, y direction
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 41
- Forks
- 12
- Avg merge
- 21h 8m
- Merged PRs (30d)
- 1
Description
In GitLab by @Huite on Oct 28, 2022, 18:12
Just had a report where imod.prepare.laplace_interpolate() used the ibound in a flipped manner in the y-axis.
This was caused by a reindex_like from xarray which does this. Since xarray doesn't really care about ascending or descending coordinates, we should generally check everywhere, including here.
Could be included in a broader thing where we try and do some more validation for all the utility functions.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at imod.prepare.laplace_interpolate and inspect how reindex_like handles x and y coordinate direction, especially the flipped y-axis case described in the report. Reproduce the issue with ascending and descending coordinates; done means the ibound is handled correctly and direction validation is covered.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100