Deltares / Deltares/imod-python

MDAL requires float/double for data variables

Open
#260 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
41
Forks
12
Avg merge
21h 8m
Merged PRs (30d)
1

Description

In GitLab by @Huite on Jul 28, 2022, 16:55

Just found out: MDAL refuses to show data if ANY of the data associated with the mesh is not of float/double dtype.

I think this the underlying cause of having to convert datetime to float as well -- it's a more a general issue with any "data" variable coordinate containing integer (or something else) data. See: https://github.com/lutraconsulting/MDAL/issues/348

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the MDAL failure described in the issue with mesh data variables using integer or other non-float dtypes, including datetime values. Investigate how imod-python passes these variables to MDAL and compare the behavior with the linked MDAL issue. Done means MDAL can display mesh data without requiring every data variable to be float or double.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.