Deltares / Deltares/imod-python

mf6 uzf: add a function to determine cell_id for the UZF package based on idomain

Open
#256 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
41
Forks
12
Avg merge
21h 8m
Merged PRs (30d)
1

Description

In GitLab by @Huite on Jul 18, 2022, 14:16

Based on the idomain, and a number of top layers, determine which cells should be used.

def uzf_cell_id(idomain, n_uzf_layers=1):
    ...
    return cell_id, landflag, ivertcon, top_or_not

Then vertical conductivity (vks) could be extracted via the cell ID.

Additionally, warnings or errors should be raised if the celltype is inappropriate (it should be phreatic), or when thicknesses in combination with surface depths are inappropriate.

I think imod.prepare is the most logical namespace for this.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the imod.prepare namespace and review the existing UZF package preparation entry points. The work is complete when a function determines cell_id, landflag, ivertcon, and top_or_not from idomain and the layer count, and reports inappropriate cell types or thickness and surface-depth combinations.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.