Deltares / Deltares/imod-python

Saving (mf6) packages: "derative" packages should not be saved by default

Open
#254 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
41
Forks
12
Avg merge
21h 8m
Merged PRs (30d)
1

Description

In GitLab by @Huite on Jul 15, 2022, 15:00

A package like the SSM package for solute transport is derived from e.g. river, drain, ghb, etc. This means that when a river is changed, the SSM should be rederived.

It's useful to dump a package as a netCDF, but this should (arguably) be disabled for the SSM package. At the least, when a model or simulation method is called that dumps to netCDF, it should skip the SSM package (and other eventual derived packages).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the model or simulation methods that dump packages to netCDF, then inspect how the SSM package is identified as derived from river, drain, and GHB packages. Done means derived packages such as SSM are skipped by default while ordinary packages can still be saved.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.