Deltares / Deltares/imod-python
Subselection grids result in incorrect cell IDs in list-based input
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 41
- Forks
- 12
- Avg merge
- 21h 8m
- Merged PRs (30d)
- 1
Description
In GitLab by @Huite on Jun 23, 2022, 13:57
The conversion functions from dense numpy arrays to recarrays currently only takes into account that the layer is not available for the entire domain, but not for x or y (or other coordinates, like in DISV/DISU).
Either the coordinates should be forwarded and used in the conversion, or an error should be raised in case "illegal" subselections are detected.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the conversion functions from dense NumPy arrays to recarrays and reproduce a subselection on a list-based input, including x or y coordinates and DISV/DISU cases. Done means cell IDs remain correct when coordinates are forwarded, or illegal subselections consistently raise an error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- numpy, python
- Domain
- data
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 45/100