Deltares / Deltares/imod-python

Force dimension order of packages

Open
#239 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
41
Forks
12
Avg merge
21h 8m
Merged PRs (30d)
1

Description

In GitLab by @Huite on May 11, 2022, 10:00

Just ran into an issue where I was getting negative layer thickness due to:

bottom: layer, y, x

versus

top: y, x, layer

Then when calling .values on the DataArray, the values are not aligned.
Friendliest might be to call a transpose on the DataArray, and let xarray sort it out.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how package DataArrays are assembled and how their dimensions are ordered before .values is called. Check whether transposing the DataArray resolves the mismatch between layer, y, x and y, x, layer; done means package values remain correctly aligned regardless of the input order.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.