Deltares / Deltares/imod-python
[FEATURE] - Support optional columns MetaSWAP
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 41
- Forks
- 12
- Avg merge
- 21h 8m
- Merged PRs (30d)
- 1
Description
For the LHM, we could get away with only supporting the columns which are required for that specific model.
For example, for ScalingFactors, we either support excluding the package, or including it with data for all variables, being required or optional. This has the problem that depth of the perched water table is an optional variable, and needs to be NOT specified to turn it off.
For IBRAHYM, I'm now running into the fact that scaling factors are provided, but the depth perched water table is turned off. The MetaSWAP IO manual mentions this is an optional column.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how MetaSWAP ScalingFactors columns are read and validated, comparing the LHM and IBRAHYM cases described in the issue. Confirm how optional variables such as perched-water-table depth are represented when disabled, and consider the work complete when required columns still work while optional columns can be omitted or turned off.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100