Deltares / Deltares/imod-python
[Bug] - MetaSWAP area computed differently from iMOD5
Open
Nobody has claimed this yet.
backwards_compatibility
bug
- Dominant language
- Python
- Stars
- 41
- Forks
- 12
- Avg merge
- 21h 8m
- Merged PRs (30d)
- 1
Description
Bug description
@Ydrolog just discovered the following differences between iMOD5 and iMOD Python.
- A second SVAT is placed whenever urban area > 0, but iMOD5 additionally filters cells with a wetter_area snmaller than ~20%
- iMOD5 is subtracting the wetter area from the area from the cell. iMOD Python attempts to do this as well, but doesn't seem to do this correctly. In his case it resulted in com[uted areas ranging from 625 to ~621.2 instead of 625 to 0 (for 25m cells).
- iMOD5 excludes cell with 100% wetter area, whereas iMOD Python includes it
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the MetaSWAP area computation and comparing its behavior with the three iMOD5 cases described: the wetter-area threshold, subtraction from the cell area, and 100% wetter-area cells. Done means the computed areas and SVAT placement match iMOD5 for these cases; no file or test location is provided in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100